-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating basic type command for VDB #89
base: vdb
Are you sure you want to change the base?
Conversation
Changed merge target to BRL-CAD:vdb, this shouldn't merge to main until the primitive is complete. This commit changes a lot of indentation unnecessarily, please fix that |
Thank you for adding the code in the correct branch. My vdb is only a bounding box at the moment to make it easier for me to understand if the data is at the correct place. The ray intersection calculation is getting the data correctly and computing the intersection. Next step might be adding a actual vdb now. |
@@ -125,6 +125,7 @@ __BEGIN_DECLS | |||
#define RT_TGC_INTERNAL_MAGIC 0xaabbdd87 /**< ???? */ | |||
#define RT_TOR_INTERNAL_MAGIC 0x9bffed87 /**< ???? */ | |||
#define RT_VOL_INTERNAL_MAGIC 0x987ba1d0 /**< ?{?? */ | |||
#define RT_VDB_INTERNAL_MAGIC 0xa7a3d52a /**< vdb */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since all the macro name corresponds to ASCII representation of the hex numbers which gives a hint of what they means. For e.g. below 706e7473
means pnts
. So similarly you can change vdb
to 76646220
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I will do that.
@@ -30,6 +30,7 @@ | |||
#include <set> | |||
#include <string> | |||
#include <vector> | |||
#include <iterator> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set
library already has member type iterator
that is used here in line 76 std::set<std::string>::iterator s_it;
. So no need to include iterator
library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that because I was getting an error on line 261 and 262: error C2039: 'inserter': is not a member of 'std'.
That was fixed by adding the include.
…acing image (light mordel = surface normals)
…ow but it is a start
…etting all the hit as it should
…e and remove variable that it is not being used
…n function) and calculating t-out for the ray tracing
Creating the basic structure to load a new type on the mged project.
If someone runs mged and do the command "make vdbName vdb" it will run the code correctly but the ray tracing function it is missing and an error will appears. The program does not break.